Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing wording in Asset Pipeline guide [ci skip] #38782

Merged
merged 6 commits into from
Mar 24, 2020

Commits on Mar 21, 2020

  1. Clean up leftover plural references in Asset Pipeline guide

    Prior to ab123a3, this guide mentioned
    that three gems (sass-rails, uglifier, and coffee-rails) would be added
    to the Gemfile by default, unless the `--skip-sprockets` option was
    used when generating the application.
    However, ab123a3 removed uglifier and
    coffee-rails from the guide (to reflect the switch to webpacker for
    managing javascript in rails 6). Now that only sass-rails is left, the
    guide should say "adding this to your Gemfile" instead of "adding them
    to your Gemfile" and "add that gem" instead of "add those gems".
    
    [ci skip]
    rmacklin committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    89f1c96 View commit details
    Browse the repository at this point in the history
  2. Clarify what sass-rails is used for in Asset Pipeline guide

    The original text "used by Sprockets for asset compression" was written
    when this sentence was summarizing the purpose of three gems:
    sass-rails, uglifier, and coffee-rails.
    However, ab123a3 removed uglifier and
    coffee-rails from this sentence. Now that only sass-rails is left, we
    can be more specific about what it is used for: compiling Sass
    stylesheets.
    
    [ci skip]
    rmacklin committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    f3f3a30 View commit details
    Browse the repository at this point in the history
  3. Link to the sass-rails repo and sass-lang.com in Asset Pipeline guide

    We link to the sprockets-rails repository in the preceding paragraph,
    so it seems appropriate to also link to the sass-rails repository in
    this paragraph. And since readers of this guide may not know what Sass
    is, it also seems appropriate to link to the sass-lang.com website.
    
    [ci skip]
    rmacklin committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    e4f4ebd View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Further reword Asset Pipeline guide introduction to be less repetitive

    [ci skip]
    
    Co-Authored-By: Eugene Kenny <elkenny@gmail.com>
    rmacklin and eugeneius committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    fd9a032 View commit details
    Browse the repository at this point in the history
  2. Remove mention of generating CoffeeScript files in Preprocessing section

    of the Asset Pipeline guide
    
    This section previously declared that the Rails controller generator
    generated an `app/assets/javascripts/projects.coffee` and an
    `app/assets/stylesheets/projects.scss` file. Then, in
    ab123a3, we removed the assertion that
    `app/assets/javascripts/projects.coffee` would be generated (to reflect
    the switch to webpacker for managing javascript in Rails 6). However,
    the preceding sentence and the subsequent paragraph were still written
    with the assumption that a CoffeeScript file would be generated.
    
    Now we've reworded those parts to be consistent with the fact that Rails
    no longer generates a CoffeeScript file.
    
    [ci skip]
    rmacklin committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    e71692f View commit details
    Browse the repository at this point in the history
  3. Remove mention of the deprecated sass gem from Asset Pipeline guide

    As of rails/sass-rails@409d871
    sass-rails no longer uses the `sass` gem (which is no longer
    maintained; it has been replaced by the `sassc` gem). Thus, the rails
    guides should not mention the `sass` gem specifically. Instead, they can
    continue to reference the `sass-rails` gem.
    
    [ci skip]
    rmacklin committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    649d265 View commit details
    Browse the repository at this point in the history