Convert CoffeeScript to ES6 syntax #38974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspth
reviewed
Apr 17, 2020
| @@ -15,8 +15,8 @@ module ActionCableHelper | |||
| # Your CoffeeScript can then connect to the server without needing to specify the | |||
|
Please squash to 1 commit 🙏 |
This PR allows for passing `if_exists` options to the `remove_index` method so that we can ignore already removed indexes. This work follows column `if/if_not_exists` from #38352 and `:if_not_exists` on `add_index` from #38555. We've found this useful at GitHub, there are migrations where we don't want to raise if an index was already removed. This will allow us to remove a monkey patch on `remove_index`. I considered raising after the `index_name_for_remove` method is called but that method will raise if the index doesn't exist before we get to execute. I have a commit that refactors this but after much consideration this change is cleaner and more straightforward than other ways of implementing this. This change also adds a little extra validation to the `add_index` test. Fix `nodoc` on edited methods.
Since 04cfbc8, a keepfile is generated in `tmp/pids/` to ensure that the directory always exists. However, the gitignore pattern for `/tmp/*` meant it wasn't tracked in git. To override that pattern we have to allow the `tmp/pids/` directory, ignore everything inside it, then finally allow `tmp/pids/.keep` again.
Follow up to 404e1a0.
Convert CoffeeScript to ES6 syntax
|
The rebase has pulled the last 5 commits into this branch as well. |
|
🤔 I think it should be enough to pull latest master (from upstream) and rebase you branch against master and force push. |
|
Whatever’s easier for you ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert CoffeeScript to ES6 syntax for the example in the comments.