Reject hexadecimal numbers with signs while validating numericality

[nimish-mehta]

Given the following class definition

class User < ApplicationRecord
  validates :email, presence: true
  validates :age, numericality: true
end

Currently '0x11' is validated as not a number. But '0x11' and '-0x11' pass the validation but parsed value is 0 and -0 respectively.

irb(main):004:0> User
=> User(id: integer, email: text, age: decimal, created_at: datetime, updated_at: datetime)

irb(main):008:0> u = User.new(email: 'abc', age: '0x11')
=> #<User id: nil, email: "abc", age: 0.0, created_at: nil, updated_at: nil>
irb(main):009:0> u.valid?
=> false
irb(main):010:0> u.errors.full_messages
=> ["Age is not a number"]

irb(main):011:0> u = User.new(email: 'abc', age: '+0x11')
=> #<User id: nil, email: "abc", age: 0.0, created_at: nil, updated_at: nil>
irb(main):012:0> u.valid?
=> true


irb(main):013:0> u = User.new(email: 'abc', age: '-0x11')
=> #<User id: nil, email: "abc", age: -0.0, created_at: nil, updated_at: nil>
irb(main):014:0> u.valid?
=> true

[eugeneius]

Thanks! This regressed in #35010, as previously BigDecimal() would have rejected those values.