Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate passing a column to type_cast #39106

Merged
merged 1 commit into from
May 2, 2020

Commits on May 1, 2020

  1. Deprecate passing a column to type_cast

    The type information for type casting is entirely separated to type
    object, so if anyone does passing a column to `type_cast` in Rails 6,
    they are likely doing something wrong. See the comment for more details:
    
    https://github.com/rails/rails/blob/28d815b89487ce4001a3f6f0ab684e6f9c017ed0/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb#L33-L42
    
    This also deprecates passing legacy binds (an array of `[column, value]`
    which is 4.2 style format) to query methods on connection. That legacy
    format was kept for backward compatibility, instead of that, I've
    supported casted binds format (an array of casted values), it is easier
    to construct binds than existing two binds format.
    kamipo committed May 1, 2020
    Configuration menu
    Copy the full SHA
    92360e9 View commit details
    Browse the repository at this point in the history