Ensure array passed to preloader has no duplicate records by object_id #39156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ! |
kamipo
reviewed
May 5, 2020
activerecord/lib/active_record/associations/preloader/association.rb
Outdated
Show resolved
Hide resolved
bogdan
force-pushed
the
preloader-duplicate-object-ids
branch
from
d64e25f
to
3d76110
Compare
kamipo
added a commit
that referenced
this pull request
May 5, 2020
Ensure array passed to preloader has no duplicate records by object_id
|
@kamipo will there be a backport? |
|
Already done a4b20e4. |
krasnoukhov
pushed a commit
to simplepractice/rails
that referenced
this pull request
Jul 2, 2020
…-ids Ensure array passed to preloader has no duplicate records by object_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39073, #39035
Summary
Duplicate records by
idare possible for preloader because ofjoins. However, if duplicate objects equal byobject_idare passed, the best fix would be to just remove duplicates.Other Information
Even though the issue #39073 is only happening for
thoughassociation, it is better to implement the fix insideAssociationPreloaderbecause in this way it is going to affect direct usage ofPreloaderclass which are no officially documented but very popular anyway.cc @inkstak @kamipo @alipman88