Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure sqlite3_mem transaction tests run in memory #39158

Merged
merged 1 commit into from
May 6, 2020
Merged

Ensure sqlite3_mem transaction tests run in memory #39158

merged 1 commit into from
May 6, 2020

Commits on May 6, 2020

  1. Ensure sqlite3_mem transaction tests run in memory 

    SQLite3 does not recognize paths as file URIs unless the
`SQLite3::Constants::Open::URI` flag is set.  Therefore, without this
flag, a path like "file::memory:" is interpreted as a filename, causing
a "file::memory:" file to be created and used as the database.  Most
tests in `SQLite3TransactionTest` picked up this flag from
`shared_cache_flags`, but a few did not.  Because those tests were
creating a file, the path was changed in rails#38620 such that it no longer
pointed to an in-memory database.

This commit restores the database path as "file::memory:" and ensures
the URI flag is set whenever `in_memory_db?` is true.
    @jonathanhefner
    jonathanhefner committed May 6, 2020
    Configuration menu
    Copy the full SHA
    c806be3 View commit details
    Browse the repository at this point in the history