Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rendering templates with . in the name #39164

Merged
merged 1 commit into from
May 6, 2020

Commits on May 6, 2020

  1. Deprecate rendering templates with . in the name

    Allowing templates with "." introduces some ambiguity. Is index.html.erb
    a template named "index" with format "html", or is it a template named
    "index.html" without a format? We know it's probably the former, but if
    we asked ActionView to render "index.html" we would currently get some
    combination of the two: a Template with index.html as the name and
    virtual path, but with html as the format.
    
    This deprecates having "." anywhere in the template's name, we should
    reserve this character for specifying formats. I think in 99% of cases
    this will be people specifying `index.html` instead of simply `index`.
    
    This was actually once deprecated in the 3.x series (removed in
    6c57177) but I don't think we can rely
    on nobody having introduced this in the past 8 years.
    jhawthorn committed May 6, 2020
    Configuration menu
    Copy the full SHA
    dd9991b View commit details
    Browse the repository at this point in the history