Adds a rails test:all rake task #39221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This task runs all tests, including system tests.
dhh
reviewed
May 11, 2020
| @@ -23,6 +23,12 @@ namespace :test do | |||
| # If used with Active Record, this task runs before the database schema is synchronized. | |||
| end | |||
|
|
|||
| desc "Runs all tests, even system tests" | |||
| task all: "test:prepare" do | |||
There was a problem hiding this comment.
Can't we just make this task dependent on test and test:system?
dhh
reviewed
May 11, 2020
| @@ -23,6 +23,12 @@ namespace :test do | |||
| # If used with Active Record, this task runs before the database schema is synchronized. | |||
| end | |||
|
|
|||
| desc "Runs all tests, even system tests" | |||
There was a problem hiding this comment.
Maybe just "run all tests, including system tests"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task runs all tests, including system tests.
Summary
Following this discussion I started to add this (new? 2a31ea5) rake task.
Other Information
I added a notice in the test guides for this new rake task, but maybe I should add why
bin/rails testdoes not run all test per default. What do you think?