Type cast pluck values for table name unqalified column in joins tables
#39292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bles Follow up to rails#39264, and fixes demonstrated case in rails#39290. If the column has no type caster and the model don't know the attribute, let's will attempt to lookup cast type from join dependency tree.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
May 14, 2020
…ns tables Follow up of rails#39292 and rails#39259.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
May 28, 2020
Related to rails#39292. Fixes rails#39460.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #39264, and fixes demonstrated case in #39290.
If the column has no type caster and the model don't know the attribute,
let's will attempt to lookup cast type from join dependency tree.
cc @eileencodes