Validate options when managing columns and tables. #39659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
validate_migration_options
branch
2 times, most recently
from
a239c59
to
2cc563f
Compare
tgxworld
force-pushed
the
validate_migration_options
branch
4 times, most recently
from
4da4778
to
0380636
Compare
tgxworld
force-pushed
the
validate_migration_options
branch
3 times, most recently
from
5388242
to
6d2a877
Compare
tgxworld
changed the title
tgxworld
force-pushed
the
validate_migration_options
branch
8 times, most recently
from
8719de3
to
07709a2
Compare
tgxworld
force-pushed
the
validate_migration_options
branch
from
07709a2
to
b07b9f9
Compare
tgxworld
commented
Jun 19, 2020
| @@ -16,6 +16,13 @@ def self.find(version) | |||
| V6_1 = Current | |||
|
|
|||
| class V6_0 < V6_1 | |||
| def method_missing(method, *arguments, &block) | |||
There was a problem hiding this comment.
I'm not sure if we should be more explicit here and list all the SchemaStatments method that we're trying to override.
|
@rafaelfranca @eugeneius Would you mind reviewing this PR as you originally reviewed #33347? Thank you in advanced. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This is still relevant. |
|
@rafaelfranca Do you think we can try and land this in Rails 6.1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33284
Resolves #39230