Prioritize db_config for current env when resolving config. #39791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
prioritize_db_config_in_current_env
branch
from
91aa7c2
to
04443b2
Compare
tgxworld
changed the title
tgxworld
commented
Jul 7, 2020
| (db_config.for_current_env? && db_config.name == env.to_s) | ||
| end | ||
| configurations | ||
| .sort_by { |db_config| db_config.for_current_env? ? 0 : 1 } |
There was a problem hiding this comment.
I'm disregarding the fact that we're doing two loops here since the size of the configurations array should be fairly small.
|
Thanks for opening this PR! I can't think of a better way to fix this problem so this change seems fine to me. |
|
@eileencodes Thank you for reviewing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #38440 (comment)
Resolves #36894 (comment)