CVE-2020-8163: regression fix #39806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beuc
force-pushed
the
CVE-2020-8163-regression
branch
from
b1eff10
to
9bdb8b8
Compare
Allow again the following non-reserved local names: _ arg args block Closes: rails#39301
Beuc
force-pushed
the
CVE-2020-8163-regression
branch
from
9bdb8b8
to
1cd1e6c
Compare
|
(Adjusted syntax so |
|
@Beuc this passed in my test suite 💯 , much appreciated! |
|
@rafaelfranca will this replace the 4.2.11.3 build on RubyGems or should I just source from this github branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow again the following non-reserved local names:
_ arg args blockCloses: #39301
Other Information
See rationale at #39301 (comment)
Tested notably against redmine 3.4
Includes tests backported from current rails.
ruby -I actionview/lib:actionview/test actionview/test/template/compiled_templates_test.rb