Shorten inspect on ActionDispatch::Request #40173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
reviewed
Sep 4, 2020
Comment on lines
1305
to
1308
| assert_match %r(#<ActionDispatch::Request method="POST"), request.inspect | ||
| assert_match %r(original_url="https://glu.ttono.us/path/of/some/uri\?mapped=1"), request.inspect | ||
| assert_match %r(remote_ip="1.2.3.4"), request.inspect | ||
| assert_match %r(media_type="application/x-www-form-urlencoded">), request.inspect |
There was a problem hiding this comment.
Suggested change
| assert_match %r(#<ActionDispatch::Request method="POST"), request.inspect | |
| assert_match %r(original_url="https://glu.ttono.us/path/of/some/uri\?mapped=1"), request.inspect | |
| assert_match %r(remote_ip="1.2.3.4"), request.inspect | |
| assert_match %r(media_type="application/x-www-form-urlencoded">), request.inspect | |
| assert_equal '#<ActionDispatch::Request method="POST", original_url="https://glu.ttono.us/path/of/some/uri?mapped=1", remote_ip="1.2.3.4", media_type="application/x-www-form-urlencoded">', request.inspect |
Small suggestion but I think we can just test the entire string without having to regexp match on parts of it.
There was a problem hiding this comment.
I think it's kind of long. Maybe the output of inspect can be shortened to just:
#<ActionDispatch::Request POST "https://glu.ttono.us/path/of/some/uri?mapped=1">
There was a problem hiding this comment.
@tgxworld I've shortend the output to same format as used for requests in the logs. This also allows the assertion to use a single line without getting to long.
"#<ActionDispatch::Request POST "https://example.com/path/of/some/uri?q=1" for 1.2.3.4>"
esparta
reviewed
Sep 4, 2020
Calling request in an action of a controller generates an endless stream of
characters, including the Rack app and middlewares.
This can be frustrating when using a debugger in a controller and
accidentally calling `request` generates output for a couple of seconds.
Inspect on ActionDispatch::Request is shortened to the most relevant
attributes and uses the same format as used for request in the logs:
"#<ActionDispatch::Request POST "https://example.com/path/of/some/uri?q=1" for 1.2.3.4>"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Calling
requestin an action of a controller generates an endless stream ofcharacters, including the Rack app and middlewares.
This can be frustrating when using a debugger in a controller and
accidentally calling
requestgenerates output for a couple of seconds.Inspect on ActionDispatch::Request is shortened to relevant attributes:
Other Information
This pull request splits an older pull request into two separate pull requests.
#39439
Edit:
I've changed the output to use the same format as used for requests in the logs: