Return rows affected from batched update_all and delete_all #40293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great refactoring! |
The previous return value of nil was undocumented and inconsistent with the non-batched versions of these methods. Also lean on `each` to create the batches, and add API documentation for `update_all`, `delete_all`, and `destroy_all` on `BatchEnumerator`.
eugeneius
force-pushed
the
batched_rows_affected
branch
from
eca1cdb
to
80e73ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40287.
The previous return value of nil was undocumented and inconsistent with the non-batched versions of these methods.
Also lean on
eachto create the batches, and add API documentation forupdate_all,delete_all, anddestroy_allonBatchEnumerator.