Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: TimeWithzone bug #40448

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Fix: TimeWithzone bug #40448

merged 1 commit into from
Oct 30, 2020

Commits on Oct 25, 2020

  1. Fix: timezone bug - rounding problem 

    Why this commit?

   TimeWithZone instances were unexpectedly being rounded up.

What changes were made and why?

   Internally, .to_f was being called on TimeWithZone instances.
This can lead to inaccuracies if Rationals are involved. Using .to_r
instead of .to_f will be more accurate, but it does come with a
slight computational cost.
    @benkoshy
    benkoshy committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    0719b94 View commit details
    Browse the repository at this point in the history