Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor stream test connection setup #40458

Conversation

tahsin352
Copy link
Contributor

@tahsin352 tahsin352 commented Oct 26, 2020

Summary

Modularize code, add connection setup and use connection as instance variable.

@p8
Copy link
Member

p8 commented Oct 26, 2020

Hi @tahsin352, thanks for contributing to Rails, but cosmetic changes are generally not accepted.
See: #13771 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants