Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only replace existing pools in transactional tests #40487

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Only replace existing pools in transactional tests #40487

merged 1 commit into from
Oct 29, 2020

Commits on Oct 29, 2020

  1. Only replace existing pools in transactional tests 

    `setup_shared_connection_pool` replaces reading connection pools with
writing ones, so that replica reads work as they would in production.

If a shard doesn't have a reading connection we should skip it, since
adding one could lead to code that only works in the test environment.
    @eugeneius
    eugeneius committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    5c562a6 View commit details
    Browse the repository at this point in the history