Increasing Puma's worker timeout in development #40503
Conversation
Actually, I think it's just byebug. I can't think of a better way to solve this issue tbh. |
| # Specifies the `worker_timeout` threshold that Puma will use to wait before | ||
| # terminating a worker in development environments. | ||
| # | ||
| worker_timeout 3600 if ENV.fetch("RAILS_ENV") == "development" |
There was a problem hiding this comment.
RAILS_ENV can be unset so ENV.fetch("RAILS_ENV") will fail. I think we should default to "development" inside a block.
There was a problem hiding this comment.
Will this work? Or is the block format better?
| worker_timeout 3600 if ENV.fetch("RAILS_ENV") == "development" | |
| worker_timeout 3600 if ENV.fetch("RAILS_ENV", "development") == "development" |
There was a problem hiding this comment.
This also work. Feel free to apply and make sure all commits are squashed in one.
juanmanuelramallo
force-pushed
the
increase-worker-timeout-in-development
branch
from
3dca423
to
e5851c6
Compare
After Puma's version 5, a worker timeout check was added, causing all debugging sessions (byebug, binding.irb, ...) to be terminated after a minute is passed. One minute timeout is fine for production environments but not for development, when we usually debug stuff and need more than a minute to do so. This PR updates Puma's config template file to include a worker timeout of one hour, only for development environments.
juanmanuelramallo
force-pushed
the
increase-worker-timeout-in-development
branch
from
e5851c6
to
b43ede6
Compare
| # Specifies the `worker_timeout` threshold that Puma will use to wait before | ||
| # terminating a worker in development environments. | ||
| # | ||
| worker_timeout 3600 if ENV.fetch("RAILS_ENV", "development") == "development" |
There was a problem hiding this comment.
👋 since you don’t care whether RAILS_ENV is set or not, would it make sense to express it as something more concise?
| worker_timeout 3600 if ENV.fetch("RAILS_ENV", "development") == "development" | |
| worker_timeout 3600 if ENV["RAILS_ENV"] == "development" |
There was a problem hiding this comment.
If ENV["RAILS_ENV"] is unset, the environment is development by default, and the setting should be enabled.
…out-in-development Increasing Puma's worker timeout in development
Summary
After Puma's version 5, a worker timeout check was added, causing all
debugging sessions (byebug, binding.irb, ...) to be terminated after a
minute is passed.
One minute timeout is fine for production environments but not for
development, when we usually debug stuff and need more than a minute to
do so.
This PR updates Puma's config template file to include a worker timeout
of one hour, only for development environments.
Other Information
This panned out after puma/puma#2443 (comment) @nateberkopec's comment.