Change the default digest for new apps to SHA256 #41043
Merged
+37
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
force-pushed
the
default-sha256-digest
branch
2 times, most recently
from
b78f105
to
5254f74
Compare
rafaelfranca
reviewed
Jan 7, 2021
There was a problem hiding this comment.
Thank you for continue working on this. Changes looks good so far. We still need to add the the new frameworks default file that is generated inside the app like this commit c7fca84. Can you make the changes?
As mentioned in rails#40770 (comment) we should default to SHA256 where SHA1 is used today. This switches over the ActiveSupport::Digest to use SHA256 for new applications. It also updates the constants to always refer to and use the OpenSSL constants as well, as also discussed in that PR.
dbussink
force-pushed
the
default-sha256-digest
branch
from
5254f74
to
ba9207f
Compare
@rafaelfranca Added this! Also fixed some typos in the existing things that you added while I was at it. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in #40770 (comment) we should default to SHA256 where SHA1 is used today. This switches over the ActiveSupport::Digest to use SHA256 for new applications.
It also updates the constants to always refer to and use the OpenSSL constants as well, as also discussed in that PR.