Unite Active Storage configs in load_defaults '6.1' into one if-section
#41054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see your point but now the two queues resetting sections are away from each other. What about moving the variants config to the queues section? (and adding a newline in between them). |
…tion When I was comparing 'defaults' for 6.1 in this method and our configuring guide, I was confused that some active_storage options are missing. This change doesn't bring any implementation changes and feels like a cosmetic change. Please feel free to close this if you think so and don't see that we could benefit this change.
bogdanvlviv
force-pushed
the
unify-active_storage-configs-in_load_defaults_6_1
branch
from
c6c8f51
to
5e0d451
Compare
|
@kaspth It is a good idea. I've amended this PR. |
|
Awesome! Exactly this, thank you 🙌 |
bogdanvlviv
deleted the
unify-active_storage-configs-in_load_defaults_6_1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was comparing 'defaults' for 6.1 in this method and our configuring
guide, I was confused that some active_storage options are missing.
This change doesn't bring any implementation changes and feels like
a cosmetic change. Please feel free to close this if you think so and don't
see that we could benefit this change.