Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid testing Thor internals #41203

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Avoid testing Thor internals #41203

merged 1 commit into from
Jan 21, 2021

Commits on Jan 21, 2021

  1. Avoid testing Thor internals 

    Thor's `apply` method is responsible for fetching a template when given
a URL.  Therefore, assume that `apply` behaves correctly, and simply
test that `apply` is called correctly.

This avoids errors like https://buildkite.com/rails/rails/builds/74245#540ecdf1-58ea-470a-a397-09f675520eb9/1100-1109
resulting from rails/thor@4ce38c5.
    @jonathanhefner
    jonathanhefner committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    9495a34 View commit details
    Browse the repository at this point in the history