Fix scope_for_create to take only equality nodes
#41319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related rails#39683. If a scope has IN cluase, `scope_for_create` which is passed to `assign_attributes` will include array values, and it will cause weird behaviors. That behavior was due to the `In` node was a subclass of the `Equality` node (now the checking has migrated to `equality?` method). i.e. It works unless IN queries, for example (BETWEEN): ```ruby user = User.where(role: 0..1).find_or_initialize_by(name: "name") ``` I think that the `In` node was a subclass of the `Equality` node is accidental, so the behavior is almost a bug to me. This makes `scope_for_create` takes only equality nodes to fix the issue. Fixes rails#41295.
|
@kamipo thanks! 🙇 |
rafaelfranca
pushed a commit
that referenced
this pull request
Feb 10, 2021
Fix `scope_for_create` to take only equality nodes
|
Just linking for information purposes - this change broke the globalize gem when going from 6.1.2 to 6.1.3. Will patch |
pixeltrix
added a commit
to pixeltrix/globalize
that referenced
this pull request
May 2, 2021
In rails/rails#41319 the `scope_for_create` method was changed so that it called `where_clause.to_h` directly and now bypasses the patched version of `where_values_hash`. This means we now have to override `scope_for_create` in Rails 6.1.3 and later. Fixes globalize#776
pixeltrix
added a commit
to pixeltrix/globalize
that referenced
this pull request
May 12, 2021
In rails/rails#41319 the `scope_for_create` method was changed so that it called `where_clause.to_h` directly and now bypasses the patched version of `where_values_hash`. This means we now have to override `scope_for_create` in Rails 6.1.3 and later. Fixes globalize#776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #39683.
If a scope has IN cluase,
scope_for_createwhich is passed toassign_attributeswill include array values, and it will cause weirdbehaviors.
That behavior was due to the
Innode was a subclass of theEqualitynode (now the checking has migrated to
equality?method).i.e. It works unless IN queries, for example (BETWEEN):
I think that the
Innode was a subclass of theEqualitynode isaccidental, so the behavior is almost a bug to me.
This makes
scope_for_createtakes only equality nodes to fix theissue.
Fixes #41295.