Fix build multiple records on association relation to not lose scope values
#41342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e values I've realized in rails#41102, even in main branch `build` multiple records in a `scoping` will lose scope values. Call `scoping` for each record to fix the losing scope values.
kamipo
added a commit
that referenced
this pull request
Feb 5, 2021
Fix `build` multiple records on association relation to not lose scope values
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Feb 8, 2021
Follow up to rails#41342. The reason why the problem of rails#41342 occurred is that unlike `create`, `build` did not support the creation of multiple records, so it did not address the problem. It is weird that `post.commnets.where(foo: "bar").build([obj1, obj2])` is allowed but `Comment.where(foo: "bar").build([obj1, obj2])` is not allowed. To avoid the confusion, it allows `build` multiple records even on non association relation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've realized in #41102, even in main branch
buildmultiple records ina
scopingwill lose scope values.Call
scopingfor each record to fix the losing scope values.