Allow addresses to support nil values
#41381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of `:dalli_store` may have been passing an explicit `nil` parameter for the servers:
```ruby
config.cache_store = :dalli_cache, nil, { expires_in: 2.hour, compress: true }
```
If they simply changed `:dalli_cache` and `:mem_cache_store`, the existing code passes `addresses = [nil]` to Dalli (instead of `nil`), which cause exceptions when people try to access the cache:
```
> Rails.cache.fetch('foo')
NoMethodError: undefined method `match' for nil:NilClass
```
This change allows users to continue passing the explicit `nil`, making migrations from `:dalli_store` to `:mem_cache_store` simpler.
rafaelfranca
added a commit
that referenced
this pull request
Feb 9, 2021
…m_dalli_store Allow addresses to support `nil` values
This was referenced Mar 11, 2021
brendon
pushed a commit
to brendon/rails
that referenced
this pull request
Jun 17, 2021
…s_from_dalli_store Allow addresses to support `nil` values
brendon
pushed a commit
to brendon/rails
that referenced
this pull request
Jun 17, 2021
…s_from_dalli_store Allow addresses to support `nil` values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
Users of
:dalli_storemay have been passing an explicitnilparameter for the servers:If they simply changed
:dalli_cacheand:mem_cache_store, the existing code passesaddresses = [nil]to Dalli (instead ofnil), which cause exceptions when people try to access the cache:This change allows users to continue passing the explicit
nil, making migrations from:dalli_storeto:mem_cache_storesimpler.