Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encodes the uploaded file's headers #41517

Merged
merged 1 commit into from Sep 9, 2022
Merged

Encodes the uploaded file's headers #41517

merged 1 commit into from Sep 9, 2022

Conversation

brunoarueira
Copy link
Contributor

@brunoarueira brunoarueira commented Feb 22, 2021 •
edited

Summary

This pull request address the issue #38080

Fixes #38080

@rails-bot rails-bot bot added the actionpack label Feb 22, 2021
@brunoarueira brunoarueira changed the title Encodes the uploaded file's headers - Closes #38080 Encodes the uploaded file's headers Feb 22, 2021
marivaldo
marivaldo suggested changes Feb 22, 2021
View reviewed changes
actionpack/lib/action_dispatch/http/upload.rb Outdated Show resolved Hide resolved
actionpack/lib/action_dispatch/http/upload.rb Outdated Show resolved Hide resolved
@brunoarueira
Copy link
Contributor Author

@marivaldo I've applied the suggested changes!

@rails-bot
Copy link

rails-bot bot commented May 23, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label May 23, 2021
@brunoarueira
Copy link
Contributor Author

@zzak @rafaelfranca Someone could review this PR? 😄

@rails-bot rails-bot bot removed the stale label May 23, 2021
zzak
zzak reviewed May 23, 2021
View reviewed changes
Copy link
Member

@zzak zzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 This approach seems reasonable to me, but I'm not sure I have enough context to give it a 👍

@ulgut
Copy link

ulgut commented Jul 22, 2021

Hey any status on this PR?

@brunoarueira
Copy link
Contributor Author

It's depending on the rails core team to review yet

@colinbruce colinbruce mentioned this pull request Aug 9, 2021
Merged
@rails-bot
Copy link

rails-bot bot commented Oct 20, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label Oct 20, 2021
@marcelolx
Copy link
Contributor

+1

@rails-bot rails-bot bot removed the stale label Oct 20, 2021
@rails-bot
Copy link

rails-bot bot commented Jan 18, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label Jan 18, 2022
@brunoarueira
Copy link
Contributor Author

waiting for the rails team to review 😃

ping @rafaelfranca

@rails-bot rails-bot bot removed the stale label Jan 18, 2022
@rails-bot
Copy link

rails-bot bot commented Apr 18, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label Apr 18, 2022
@brunoarueira
Copy link
Contributor Author

still waiting for the rails team 😃

@rails-bot rails-bot bot removed the stale label Apr 18, 2022
@rafaelfranca rafaelfranca merged commit 4f212ef into rails:main Sep 9, 2022
rafaelfranca added a commit that referenced this pull request Sep 9, 2022
@rafaelfranca
Merge pull request #41517 from brunoarueira/fix/issue-38080-encoding-…
b26a071 
…uploaded-file-headers

Encodes the uploaded file's headers
@brunoarueira brunoarueira deleted the fix/issue-38080-encoding-uploaded-file-headers branch September 9, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzak zzak zzak left review comments

@marivaldo marivaldo marivaldo requested changes

Assignees
No one assigned
Labels
actionpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encoding of headers for ActionDispatch::Http::UploadedFile
6 participants
@brunoarueira @ulgut @marcelolx @zzak @marivaldo @rafaelfranca