Use stable branch for --edge option when not alpha #41837
Closed
+33
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to rails#41568. If a user runs `rails new --edge` with an `x.y.0.betaN` or `x.y.z.rcN` version, they most likely want to track the `x-y-stable` branch rather than `main` branch. In some cases, the `x-y-stable` branch may not exist yet. In those cases, it is better to raise an error when `bundle install` fails, so that the user knows that the branch is not available.
jonathanhefner
force-pushed
the
dynamic-edge-branch-2
branch
from
c69d595
to
9f13cf4
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Will have to think about this some more, this introduces an interesting edge case. |
I wasn't aware that the version of Rails should really matter when using
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #41568.
If a user runs
rails new --edgewith anx.y.0.betaNorx.y.z.rcNversion, they most likely want to track thex-y-stablebranch rather thanmainbranch. In some cases, thex-y-stablebranch may not exist yet. In those cases, it is better to raise an error whenbundle installfails, so that the user knows that the branch is not available.