Simplify Time.find_timezone! logic #41957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By pushing the checks for TZInfo::Timezone and ActiveSupport::TimeZone down into the case statement inside the `[]` method we can radically simplify the logic inside of the `find_timezone!` method. There's an edge case where passing an invalid argument to `[]` via the `find_timezone!` method generates a slightly different message for the `ArgumentError` exception and this is maintained in the unlikely case someone was relying on the difference.
pixeltrix
force-pushed
the
simplify-find-timezone
branch
from
797d897
to
f6893cd
Compare
rafaelfranca
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By pushing the checks for TZInfo::Timezone and ActiveSupport::TimeZone down into the case statement inside the
[]method we can radically simplify the logic inside of thefind_timezone!method.There's an edge case where passing an invalid argument to
[]via thefind_timezone!method generates a slightly different message for theArgumentErrorexception and this is maintained in the unlikely case someone was relying on the difference.