Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer (...) new argument forwarding syntax #42321

Closed

Conversation

adityapandit17
Copy link
Contributor

Prefer (...) over ruby2_keywords
(...) is already used in several places in Rails and looks nicer.

Reference :- eregon@191ee5e#comments

Comment on lines 154 to 155
def use(...)
middlewares.push(build_middleware(...))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not equivalent. See the CI build failures.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. I fixed that one.

@adityapandit17 adityapandit17 marked this pull request as draft May 31, 2021 13:43
@zzak
Copy link
Member

zzak commented May 31, 2021

Seems like there are failures in CI:

/rails/activesupport/lib/active_support/current_attributes.rb:165:in `method_missing'
--
  | /rails/activesupport/test/current_attributes_test.rb:164:in `block in <class:CurrentAttributesTest>'

@eugeneius
Copy link
Member

Thank you for the pull request, but this is a cosmetic change, which we don't accept.

Note that 191ee5e was part of #42289, which fixed a bug.

@eugeneius eugeneius closed this Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants