Allow serving compressed SVG images #42407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzak
approved these changes
Jun 7, 2021
This adds `image/svg+xml` to the compressible content types of ActionDispatch::Static
ledermann
force-pushed
the
serve-svg-with-compression
branch
from
3617fe0
to
f47c5ad
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Who should we ping to reopen this PR? |
|
I'm going to rebase and re-submit this. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
image/svg+xmlto the compressible content types ofActionDispatch::Staticso GZIP or Brotli can be used.Summary
The Webpacker gem creates compressed variants (
.gzand.br) of SVG images, but they are currently not served fromActionDispatch::Static. This PR fixes this, so the compressed file is served if present.