Remove already deprecated methods in ActiveStorage

[santib]

Summary

These methods were already deprecated on Rails 6.1, so I think it'd be appropriate to remove them for Rails 7.0

For reference, the deprecations where added here:
#34827
#37856

[p8]

Nice find!
Maybe we should add versions to that deprecate method to make them easier to find:
deprecate :build_after_upload, remove_in: '7.1'

[zzak]

Agree with @p8 I'm a bit surprised they were deprecated without mentioning the version they will be removed in 🤔

[pixeltrix]

Agree with @p8 I'm a bit surprised they were deprecated without mentioning the version they will be removed in 🤔

@zzak they'll default to the value of ActiveSupport::Deprecation.deprecation_horizon which is handled in the ActiveSupport::Reporting::Reporting module.

[pixeltrix]

@santib can you add a CHANGELOG entry, thanks - once you've added that I think we're good to go 👍🏻

[zzak]

@pixeltrix So do we normally update this value to the next version?

rails/activesupport/lib/active_support/deprecation.rb

Line 41 in 3a2205c

def initialize(deprecation_horizon = "7.1", gem_name = "Rails")

So if I had installed this gem at version 6.0, the horizon value would be 6.1?

Interesting if you look at 6.1 branch the value is a non-existant Rails version:
https://github.com/rails/rails/blob/6-1-stable/activesupport/lib/active_support/deprecation.rb#L41

Not sure how relevant this is tho, just sharing 🤔

[pixeltrix]

Yes, I'm aware of the version mismatch on 6-1-stable. Not sure if it should change or not - I'm leaning towards it should (no-one will have asserted on that value in their test suite, right? 😅 ).

[santib]

@santib can you add a CHANGELOG entry, thanks - once you've added that I think we're good to go 👍🏻

@pixeltrix I just added a CHANGELOG entry. LMK if you'd like to word it in some other way.

[pixeltrix]

@santib thanks! 👍🏻

[kamipo]

FYI usually removing all deprecated code for Rails 7.0 will be done by the release manager.

#34954
https://github.com/rails/rails/commits/main/guides/source/6_1_release_notes.md?author=rafaelfranca

[pixeltrix]

@kamipo my understanding was that these were missed for removal in 6.1, apologies if I misunderstood that.