Remove LocalCache in FileStore - #42626
Merged
Merged
Conversation
casperisfine
force-pushed
the
as-file-store-remove-local-cache
branch
from
June 28, 2021 13:22
c0a5d05 to
a2148b9
Compare
ghiculescu
added a commit
to ghiculescu/rails
that referenced
this pull request
Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #42611
Context
LocalCacheused to keep the deserialized value in memory, however this opened the door for the cached value to be mutated (see #36656 and #37587). So it used to both save the backend rountrip, and the deserialization cost.But now that we almost always need to deserialize local cache entries,
LocalCachenow at best only save the backend rountrip. And in the case of theFileStoreit's pretty much nothing.Benchmark
I used a slightly modified version of @hoangtuyb96's benchmark: https://gist.github.com/casperisfine/80620e26aaf786a9d3016d5823ade15b
So
LocalCacheis pretty much useless forFileStore.