Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #42611
Context
LocalCache
used to keep the deserialized value in memory, however this opened the door for the cached value to be mutated (see #36656 and #37587). So it used to both save the backend rountrip, and the deserialization cost.But now that we almost always need to deserialize local cache entries,
LocalCache
now at best only save the backend rountrip. And in the case of theFileStore
it's pretty much nothing.Benchmark
I used a slightly modified version of @hoangtuyb96's benchmark: https://gist.github.com/casperisfine/80620e26aaf786a9d3016d5823ade15b
So
LocalCache
is pretty much useless forFileStore
.