Allow ActiveStorage.default_url_options for DiskService #42847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceritium
force-pushed
the
disk-usage-url-options
branch
from
ab78bdd
to
58b84ae
Compare
ceritium
force-pushed
the
disk-usage-url-options
branch
from
58b84ae
to
79a28a3
Compare
ceritium
force-pushed
the
disk-usage-url-options
branch
2 times, most recently
from
4663668
to
9f13748
Compare
ceritium
force-pushed
the
disk-usage-url-options
branch
from
9f13748
to
1bb7ca6
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
rafaelfranca
reviewed
Dec 9, 2021
| @@ -160,7 +160,7 @@ def url_helpers | |||
| end | |||
|
|
|||
| def url_options | |||
| ActiveStorage::Current.url_options | |||
| ActiveStorage::Current.url_options || Rails.application.routes.default_url_options | |||
There was a problem hiding this comment.
Active Storage should not depend on the Rails application. Maybe we should inject it into the DiskService using the Engine in Active Storage?
There was a problem hiding this comment.
3b0556e, It is what you mean? Let me know what you think.
DiskService can use ActiveStorage::Current.url_options or Rails.application.routes.default_url_options (in that order) as url options.
ceritium
force-pushed
the
disk-usage-url-options
branch
2 times, most recently
from
fb1d2e4
to
2b9bdcc
Compare
….default_url_options
ceritium
force-pushed
the
disk-usage-url-options
branch
from
2b9bdcc
to
4299ae2
Compare
ceritium
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DiskServicecan useActiveStorage::Current.url_optionsorActiveStorage.default_url_options(in that order) as url options.Related to: #40855 #37841 #33549 #32590 #13372
Why
Setting
ActiveStorage::Current.hostorActiveStorage::Current.url_optionsis useful when generate the URLs fromActionController. But if you need to generate the URLs in a background job or rake task, it seems cumbersome to have to define it in another place. Also for my experience can be a bit confusing to other developers.I think that we can use
ActiveStorage::Current.url_options || ActiveStorage.default_url_optionsas source forurl_options. This approach allows override globalActiveStorage.default_url_optionswithActiveStorage::SetCurrentif needed.Other Information
If the PR receives positive feedback, I will update the guidelines in this or another PR.