fix #43146 button_to now not works with hash params for url

[qinmingyuan]

Summary

rails/actionview/lib/action_view/helpers/url_helper.rb

Lines 317 to 361 in c236ff6

	def button_to(name = nil, options = nil, html_options = nil, &block)
	html_options, options = options, name if block_given?
	options ||= {}
	html_options ||= {}
	html_options = html_options.stringify_keys
	url = options.is_a?(String) ? options : url_for(options)
	remote = html_options.delete("remote")
	params = html_options.delete("params")
	method = html_options.delete("method").to_s
	method_tag = BUTTON_TAG_METHOD_VERBS.include?(method) ? method_tag(method) : "".html_safe
	form_method = method == "get" ? "get" : "post"
	form_options = html_options.delete("form") || {}
	form_options[:class] ||= html_options.delete("form_class") || "button_to"
	form_options[:method] = form_method
	form_options[:action] = url
	form_options[:'data-remote'] = true if remote
	request_token_tag = if form_method == "post"
	request_method = method.empty? ? "post" : method
	token_tag(nil, form_options: { action: url, method: request_method })
	else
	""
	end
	html_options = convert_options_to_data_attributes(options, html_options)
	html_options["type"] = "submit"
	button = if block_given? || button_to_generates_button_tag
	content_tag("button", name || url, html_options, &block)
	else
	html_options["value"] = name || url
	tag("input", html_options)
	end
	inner_tags = method_tag.safe_concat(button).safe_concat(request_token_tag)
	if params
	to_form_params(params).each do |param|
	inner_tags.safe_concat tag(:input, type: "hidden", name: param[:name], value: param[:value])
	end
	end
	content_tag("form", inner_tags, form_options)
	end

In this line 348, name always be the hash { action: 'sync' }, url is url_for(action: 'sync'), is string

content_tag("button", { action: 'sync' }, { class: 'button is-success' }, &block),

html_options becomes { action: 'sync' }, the real html options { class: 'button is-success' } lost, if use a string as param, the param will be ignore because of block exist

[qinmingyuan]

@ rafaelfranca Could you please help review this PR, you have reviewed the PR #40747 , which broke this.

[marcelolx]

@qinmingyuan Could you add a test case and a changelog entry?

[qinmingyuan]

@qinmingyuan Could you add a test case and a changelog entry?

ok, I will do it

[rafaelfranca]

Merged in 075ffd5