Fixed bug that occurred when scaffold generated a model with nested namespace. #43365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpaca-tc
force-pushed
the
fixed_scaffold
branch
3 times, most recently
from
263bc0d
to
1bdba8e
Compare
alpaca-tc
force-pushed
the
fixed_scaffold
branch
from
1bdba8e
to
ebaced0
Compare
|
Does it need a test case to prevent regressions? |
alpaca-tc
force-pushed
the
fixed_scaffold
branch
from
ebaced0
to
635fd6f
Compare
…amespace. When I called `rails g scaffold admin/account`, scaffold generated wrong views. Because `render @admin_accounts` expects a partial view of `admin/accounts/_account`, but scaffold generates `admin/accounts/_admin_account`, so the template is not found.
alpaca-tc
force-pushed
the
fixed_scaffold
branch
from
635fd6f
to
293b25e
Compare
|
@pirj Added test to prevent regressions 👍 and force pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As a follow-up to #41210 , this commit adds a bug fix for generating scaffold with nested model
incorrectly creating a partial view.
In Rails 7.0.0.alpha2,
. /bin/rails g scaffold admin/accontwill generateapp/views/admin/_admin_account, but the correct path isapp/views/admin/_account.Assuming that the
@admin_accountsinstance variable contains an instance of theAdmin::Accountmodel, this will useadmin/accounts/_account.html.erbto render it and will pass the local variableaccountinto the partial. Unfortunately, rails7.0.0.alpha generatedadmin/accounts/_admin_account.html.erband useadmin_accountas local variable in the partial.Other Information