Fix STI in available_records causing new instances of records to be loaded from database #43524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akenneth
approved these changes
Oct 25, 2021
eileencodes
reviewed
Oct 25, 2021
eileencodes
reviewed
Oct 26, 2021
octatone
force-pushed
the
octatone/preloadSTIFix
branch
2 times, most recently
from
3d5183d
to
355deb4
Compare
eileencodes
reviewed
Oct 27, 2021
…oaded from database Removes grouping by available_record class names in ActiveRecord::Associations::Preloader::Batch so that records of differing STI classes can be located.
octatone
force-pushed
the
octatone/preloadSTIFix
branch
from
355deb4
to
2d988d0
Compare
|
@octatone Was there an associated issue with this PR or just something you picked up on and posted a patch? |
|
There's no public issue, this was found in the GitHub app @zzak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes bug in ActiveRecord::Associations::Preloader causing unnecessary refetching of records by removing grouping by available_record class names.