Enum with strings #43529
Merged
Enum with strings #43529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfassy
force-pushed
the
enum_with_strings
branch
from
4ef37c1
to
1e3395e
Compare
elfassy
force-pushed
the
enum_with_strings
branch
from
1e3395e
to
3db736b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There already seems to be support for using strings instead of integers with enums, see https://github.com/rails/rails/blob/5cdd4e5aba93e614ea286c10b7dbcc0a468497e7/activerecord/test/models/book.rb#L18 but nothing is using this in the tests.
This PR adds more tests and updates the description to make this usage explicit.
Other Information
this PR was also attempted here in 2017 and here in 2019. Comments from DHH about explaining that using non-integers is less performant have been addressed in this PR