Propagate save(validate:) option for :has_one associations on autosave
#43557
+86
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tosave. `save(validate:)` option is propagated to associated records during `autosave` when `autosave` option is `nil`. Affects only `:has_many` associations. Fixes rails#43400
|
@ghiculescu I've noted that WDYT? |
intrip
changed the title
save(validate:) option for :has_one associations on autosave
intrip
force-pushed
the
fix-43400-has-one
branch
from
ccbaf65
to
e8e0283
Compare
…osave. `save(validate:)` option is propagated to associated records during `autosave` when `autosave` option is `nil`. Affects only `:has_one` associations.
intrip
force-pushed
the
fix-43400-has-one
branch
from
e8e0283
to
eb41dc1
Compare
|
This looks great, thank you again. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
ping |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Propagate
save(validate:)option for:has_oneassociations on autosave.save(validate:)option is propagated to associated records duringautosavewhenautosaveoption isnil. Affects only:has_oneassociations.This is a follow up of #43525 for
has_oneassociations.Since #43525 has not been merged yet it also encompasses the changes done in #43525.