add render_layout.action_view asn to documentation #43939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @ericmustin! 🎉 |
rafaelfranca
pushed a commit
that referenced
this pull request
Dec 20, 2021
…tion add render_layout.action_view asn to documentation [ci-skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ActionView
render_layout.action_viewActive Support Instrumentation documentation.Noticed that an Active Support Notification for
render_layout.action_viewwas added here in this PR from the nice folks at Skylight in May of last year, but it looks like it never made it into the ASN Docs. I've updated the Docs to include it. I think it would be beneficial to document for completeness. It would also be useful to document so that Tracing libraries which rely on ASN events can offer more accurate metadata in their ActionView related Spans.Other Information
This is my first PR to Rails so please let me know if there's anything I missed. Thanks for all the great work y'all and congrats on the 7.0 release!