Fix asset pipeline errors for plugin dummy apps #44016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhefner
force-pushed
the
fix-plugin-dummy-asset-pipeline
branch
from
8ca3cd7
to
cc3594a
Compare
rafaelfranca
reviewed
Jan 5, 2022
To fix rails#43920, f292daa added `sprockets-rails` to the generated `Gemfile` for engine plugins because their dummy apps use Sprockets. However, non-engine plugins exhibit the same issue because their dummy apps also use Sprockets. This commit forces `skip_asset_pipeline` to be true when a plugin is not an engine, and fixes several tests that failed to detect these issues because they were accidentally using the `rails/rails` `Gemfile` instead of the generated plugin `Gemfile`.
jonathanhefner
force-pushed
the
fix-plugin-dummy-asset-pipeline
branch
from
cc3594a
to
330becb
Compare
rafaelfranca
added a commit
that referenced
this pull request
Jan 5, 2022
…pipeline Fix asset pipeline errors for plugin dummy apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #43920, f292daa added
sprockets-railsto the generatedGemfilefor engine plugins because their dummy apps use Sprockets. However, non-engine plugins exhibit the same issue because their dummy apps also use Sprockets.This commit forces
skip_asset_pipelineto be true when a plugin is not an engine, and fixes several tests that failed to detect these issues because they were accidentally using therails/railsGemfileinstead of the generated pluginGemfile.