Actually run a pg_dump in the Postgres test suite
#44069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiculescu
force-pushed
the
postgres-test-dump
branch
from
b374760
to
7df419e
Compare
rails#44028 came about because all the current Postgres tests just mock the `pg_dump` call made when you dump a DB structure. By actaully running a dump at least once, we can test against a real database and ensure that all arguments are correctly handled. This PR implements that.
ghiculescu
force-pushed
the
postgres-test-dump
branch
from
7df419e
to
16ed32e
Compare
|
I think the red tests are unrelated |
rafaelfranca
added a commit
that referenced
this pull request
Jan 4, 2022
Actually run a `pg_dump` in the Postgres test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44028 came about because all the current Postgres tests just mock the
pg_dumpcall made when you dump a DB structure.By actaully running a dump at least once, we can test against a real database and ensure that all arguments are correctly handled. This PR implements that.