add hint to ActionView's fields_for #44093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there seem to be quite some errors in the CI. please let me know if my documentation change caused any of this. |
No, it seems unrelated. Could you rebase against |
|
sure thing. please I just merged upstream. |
|
Thanks, could you also squash your commits please? |
motine
force-pushed
the
doc-hint-for-fields_for
branch
from
a5c4f03
to
c6cb783
Compare
|
alrighty, please check again. |
rafaelfranca
added a commit
that referenced
this pull request
Feb 10, 2022
add hint to ActionView's fields_for
|
gh pr checkout 13271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a hint to the documentation for
ActionView::Helpers::FormHelper#fields_forwhen hiddenidfields are generated.Other Information
I am a little embarrassed that this is such a small change. This missing bit of documentation had me spend unnecessary time when trying to figure out why there was no
idrendered for sub-forms.