Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ActiveStorage analyzer error message for missing ffprobe. Add… #44112

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Improve ActiveStorage analyzer error message for missing ffprobe. Add… #44112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion activestorage/lib/active_storage/analyzer/audio_analyzer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def probe_from(file)
end
end
rescue Errno::ENOENT
logger.info "Skipping audio analysis because FFmpeg isn't installed"
logger.info "Skipping audio analysis because ffprobe isn't installed"
{}
end

Expand Down
2 changes: 1 addition & 1 deletion activestorage/lib/active_storage/analyzer/video_analyzer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def probe_from(file)
end
end
rescue Errno::ENOENT
logger.info "Skipping video analysis because FFmpeg isn't installed"
logger.info "Skipping video analysis because ffprobe isn't installed"
{}
end

Expand Down
2 changes: 1 addition & 1 deletion guides/source/active_storage_overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Various features of Active Storage depend on third-party software which Rails
will not install, and must be installed separately:

* [libvips](https://github.com/libvips/libvips) v8.6+ or [ImageMagick](https://imagemagick.org/index.php) for image analysis and transformations
* [ffmpeg](http://ffmpeg.org/) v3.4+ for video/audio analysis and video previews
* [ffmpeg](http://ffmpeg.org/) v3.4+ for video previews and ffprobe for video/audio analysis
* [poppler](https://poppler.freedesktop.org/) or [muPDF](https://mupdf.com/) for PDF previews

Image analysis and transformations also require the `image_processing` gem. Uncomment it in your `Gemfile`, or add it if necessary:
Expand Down