Ensure preload_link_tag preloads modules correctly #44198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, preload_link_tag always used rel=preload This causes the browser to make a request to preload the script, but for modules scripts the rel does not match the type, so the browser can not reuse the prefetched script and discards it. When passing type="module", it should use rel=modulepreload instead. [0] developer.mozilla.org/en-US/docs/Web/HTML/Preloading_content [1] developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Link [2] developer.mozilla.org/en-US/docs/Web/HTML/Link_types/modulepreload [3] developers.google.com/web/updates/2017/12/modulepreload
rafaelfranca
added a commit
that referenced
this pull request
Jan 20, 2022
Ensure preload_link_tag preloads modules correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes
preload_link_tagto support preloading ofmodulescripts.When
type: 'module'is provided, it will now use rel: 'modulepreload' instead of rel: 'preload'.Background 馃摐
Previously, both the rendered tag and the early response hint sent in
preload_link_tagwere using rel=preload for all scripts, includingmodulescripts.Browsers will ignore the pre-loaded resource because the types don't match (preloaded a script, but included a module).
Screenshots 馃摲
References 馃敆