Add note in guide for a counter cache caveat [ci skip] #44232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khasinski
force-pushed
the
update-docs-for-counter-cache-caveats
branch
from
41761ec
to
37b123c
Compare
Counter cache can hold stale value if user changes primary key's value. This caveat is not mentioned in guides, but according to rails#16159 comments it should be.
khasinski
force-pushed
the
update-docs-for-counter-cache-caveats
branch
from
37b123c
to
ea22266
Compare
jonathanhefner
approved these changes
Jan 22, 2022
|
Thank you, @khasinski! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counter cache can hold a stale value if user changes primary key's value.
This caveat is not mentioned in guides, but according to #16159
comments it should be.
Summary
A small note for users using counter caches and updating primary keys which will result in counter cache being broken.