Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix que integration in Active Job tests #44246

Merged
merged 1 commit into from Jan 24, 2022

Conversation

skipkayhil
Copy link
Member

Summary

Que.mode was removed in que-rb/que@6783fdd
and replaced by Que.run_synchronously = true per changelog:
https://github.com/que-rb/que/blob/fa4988ee33444c5a2db379f112000330434abac1/CHANGELOG.md?plain=1#L120

It looks like it started failing because Que 1.0 was released yesterday.

Que.mode was removed in que-rb/que@6783fdd
and replaced by Que.run_synchronously = true per changelog:
https://github.com/que-rb/que/blob/fa4988ee33444c5a2db379f112000330434abac1/CHANGELOG.md?plain=1#L120

It looks like it started failing because Que 1.0 was released yesterday.
@rails-bot rails-bot bot added the activejob label Jan 24, 2022
@rafaelfranca rafaelfranca merged commit 23ce9a7 into rails:main Jan 24, 2022
rafaelfranca added a commit that referenced this pull request Jan 24, 2022
fix que integration in Active Job tests
@skipkayhil skipkayhil deleted the fix-que-integration branch January 25, 2022 00:01
rafaelfranca added a commit that referenced this pull request Mar 2, 2022
fix que integration in Active Job tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants