Fix the ability to exclude encryption params from being autofiltered #44329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvasilevski
reviewed
Feb 3, 2022
rafaelfranca
added a commit
that referenced
this pull request
Feb 8, 2022
Fix the ability to exclude encryption params from being autofiltered
|
@attack @jorgemanrubia FYI, this test has recently started failing on
https://buildkite.com/rails/rails/builds/84488#156fa457-40dd-4ced-87d4-83f42a7f22f4 |
|
Oops, sorry folks, I have renamed the method in a separate PR and should have asked for a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A bug is preventing the exclusion of params from being auto-filtered in conjunction with ActiveRecord encryption.
This fixes it by exposing the bug in a test, then using the correct variable in the code.