Include the model name when filtering encrypted attributes. #44361
+31
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvasilevski
reviewed
Feb 8, 2022
|
This only filters if the parameter is inside a form with the model name right? If anyone set a different name in the |
jorgemanrubia
force-pushed
the
qualify-encrypted-filter-params
branch
from
d24d533
to
bc92a6f
Compare
|
@rafaelfranca yes, you are correct. It will work as long as the resource/param name matches the model/attribute name. I think it's a sensible default, even knowing it won't work in all cases. The previous default was probably too coarse grained. I rebased and fixed conflicts. |
|
👍🏽 . There is a failing test though. |
jorgemanrubia
force-pushed
the
qualify-encrypted-filter-params
branch
3 times, most recently
from
3a9f4a1
to
d191135
Compare
|
Fixed that test @rafaelfranca. Build failing in an unrelated error now. |
|
just wanted to bump this PR. Sorry for the noise |
jorgemanrubia
force-pushed
the
qualify-encrypted-filter-params
branch
from
d191135
to
9c2fc77
Compare
For example, when encrypting `Person#name` it will add `person.name` as a filter parameter, instead of just `name`. This prevents unintended filtering of parameters with a matching name in other models. Closes rails#44330
jorgemanrubia
force-pushed
the
qualify-encrypted-filter-params
branch
from
9c2fc77
to
67d6183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, when encrypting
Person#nameit will addperson.nameas a filter parameter, instead of justname. This prevents unintended filtering of parameters with a matching name in other models.Addresses the second concern in #44330.
CC @rafaelfranca @nvasilevski