f.submit: Set the the value of the explicit :value option to the value of data-disable-with

[noriyotcp]

Summary

When you give the value to f.submit, the same value sets to the value of data-disable-with.

= f.submit 'Submit', class: 'btn btn-primary'

<input type="submit" name="commit" value="Submit" class="btn btn-primary" data-disable-with="Submit">

But when you give the :value option, two values are not the same.

= f.submit value: 'Submit', class: 'btn btn-primary'

<input type="submit" name="commit" value="Submit" class="btn btn-primary" data-disable-with="Create">

Create seems to come from i18n as the default value. https://github.com/svenfuchs/rails-i18n/blob/99cfa35268ad20ec1193c670a7ee2a4705140a3d/rails/locale/en.yml#L151

This PR sets the value of :value option to the value of data-disable-with

[skipkayhil]

Hey, @noriyotcp, thanks for the PR! I'm a little bit confused about the desire for this change. Is there a reason you wouldn't be able to use = f.submit 'Submit', class: 'btn btn-primary'?

It seems to me like the two different apis serve different purposes:

• the positional parameter sets both the value and data-disables-with attributes
• value: and data-disables-with: would set individual values

I think it would be surprising to me if value: set other attributes.