Update description of working with JavaScript guide [ci-skip] #44414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidColby
force-pushed
the
working-with-javascript-guide-description
branch
from
6e7f2e0
to
13d3151
Compare
|
Thank you, @DavidColby! 👍 Backported to |
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Feb 14, 2022
…t-guide-description Update description of working with JavaScript guide [ci-skip] (cherry picked from commit 25fe901)
|
@DavidColby what do you think about removing the "work in progress" warning? it would be great if the guide showed up here:
|
|
@ghiculescu I think that would be great, would love to see this guide in the main nav so it is a little easier to find for folks trying to learn. The content of this guide should be relatively stable for the life of Rails 7 at least, so this seems like a fine time to drop the WIP label. Happy to open that PR — wasn't sure if there was a formal process in place for moving guides out of WIP! |
|
Not that I know of - if the guide is stable and good, I think it’s fine to make the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#43957 was a complete rewrite of the working with JavaScript guide. The description of the guide on the guides index page is no longer accurate after this rewrite and probably should have been updated in the #43957 but I didn't think to check the description while working on that PR.
Happy to adjust the language as desired.
Other Information
Current description:
New description, after
bundle exec rake guides:generate:htmllocally, to make sure I didn't mess up any formatting this time ;)