Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require "models/post" to address NameError: uninitialized constant #44417

Merged
merged 1 commit into from Feb 13, 2022

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented Feb 13, 2022

Summary

Follow up #44408

This commit addresses Active Record isolated CI failures. Here is one of them.

$ ARCONN=sqlite3 bundle exec ruby -w -Itest -Ilib -I../activesupport/lib -I../activemodel/lib test/cases/adapters/sqlite3/bind_parameter_test.rb -n test_where_with_string_for_string_column_using_bind_parameters
Using sqlite3
Run options: -n test_where_with_string_for_string_column_using_bind_parameters --seed 21170

E

Error:
ActiveRecord::ConnectionAdapters::SQLite3Adapter::BindParameterTest#test_where_with_string_for_string_column_using_bind_parameters:
NameError: uninitialized constant ActiveRecord::ConnectionAdapters::SQLite3Adapter::BindParameterTest::Post
    test/cases/adapters/sqlite3/bind_parameter_test.rb:12:in `test_where_with_string_for_string_column_using_bind_parameters'

rails test test/cases/adapters/sqlite3/bind_parameter_test.rb:11

Finished in 0.017992s, 55.5789 runs/s, 0.0000 assertions/s.
1 runs, 0 assertions, 0 failures, 1 errors, 0 skips
$

Other isolated CI failures are also addressed.

ARCONN=sqlite3 bundle exec ruby -w -Itest -Ilib -I../activesupport/lib -I../activemodel/lib test/cases/adapters/sqlite3/bind_parameter_test.rb
ARCONN=mysql2 bundle exec ruby -w -Itest -Ilib -I../activesupport/lib -I../activemodel/lib test/cases/adapters/mysql2/bind_parameter_test.rb
ARCONN=postgresql bundle exec ruby -w -Itest -Ilib -I../activesupport/lib -I../activemodel/lib test/cases/adapters/postgresql/bind_parameter_test.rb

Follow up rails#44408

This commit addresses Active Record isolated CI failures. Here is one of
them.

```ruby
$ ARCONN=sqlite3 bundle exec ruby -w -Itest -Ilib -I../activesupport/lib -I../activemodel/lib test/cases/adapters/sqlite3/bind_parameter_test.rb -n test_where_with_string_for_string_column_using_bind_parameters
Using sqlite3
Run options: -n test_where_with_string_for_string_column_using_bind_parameters --seed 21170

E

Error:
ActiveRecord::ConnectionAdapters::SQLite3Adapter::BindParameterTest#test_where_with_string_for_string_column_using_bind_parameters:
NameError: uninitialized constant ActiveRecord::ConnectionAdapters::SQLite3Adapter::BindParameterTest::Post
    test/cases/adapters/sqlite3/bind_parameter_test.rb:12:in `test_where_with_string_for_string_column_using_bind_parameters'

rails test test/cases/adapters/sqlite3/bind_parameter_test.rb:11

Finished in 0.017992s, 55.5789 runs/s, 0.0000 assertions/s.
1 runs, 0 assertions, 0 failures, 1 errors, 0 skips
$
```

Other isolated CI failures are also addressed.

```
ARCONN=sqlite3 bundle exec ruby -w -Itest -Ilib -I../activesupport/lib -I../activemodel/lib test/cases/adapters/sqlite3/bind_parameter_test.rb
ARCONN=mysql2 bundle exec ruby -w -Itest -Ilib -I../activesupport/lib -I../activemodel/lib test/cases/adapters/mysql2/bind_parameter_test.rb
ARCONN=postgresql bundle exec ruby -w -Itest -Ilib -I../activesupport/lib -I../activemodel/lib test/cases/adapters/postgresql/bind_parameter_test.rb
```
@kamipo kamipo merged commit 09194c9 into rails:main Feb 13, 2022
rafaelfranca pushed a commit that referenced this pull request Feb 14, 2022
Add require "models/post" to address NameError: uninitialized constant
@yahonda yahonda deleted the follow_up_44408 branch February 15, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants